Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app was created #909

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Pavlo-Petrashevskyi
Copy link

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Check my comments to improve your code

src/components/Comment.tsx Outdated Show resolved Hide resolved
Comment on lines 84 to 87
onChange={(e) => {
setName(e.target.value);
setIsNameAllright(true);
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create separate handler instead of anonymous function. Try fix all places

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/components/NewCommentForm.tsx Outdated Show resolved Hide resolved
Comment on lines 36 to 40
onClick={() => {
return isPostSelected
? handleSelectPost(undefined)
: handleSelectPost(post);
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return is redundant

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/components/PostDetails.tsx Outdated Show resolved Hide resolved
Co-authored-by: Ivan Fesenko <61904995+IvanFesenko@users.noreply.github.com>
Co-authored-by: Ivan Fesenko <61904995+IvanFesenko@users.noreply.github.com>
Co-authored-by: Ivan Fesenko <61904995+IvanFesenko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants